extensions/browser/guest_view/guest_view_base.cc - Issue 531963002: Add support for file inputs for all guest views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 531963002: Add support for file inputs for all guest views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implement RunFileChooser as GuestViewBase method Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index 44b6899c951742592125df0fa2906cd385f5ed9b..1e227ccc3efc7e18946cb81d1369e7f068c994d4 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -383,6 +383,14 @@ void GuestViewBase::WebContentsDestroyed() {

delete this;

}

+void GuestViewBase::RunFileChooser(WebContents* web_contents,

+ const content::FileChooserParams& params) {

+ if (!attached() || !embedder_web_contents()->GetDelegate())

+ return;

+ embedder_web_contents()->GetDelegate()->RunFileChooser(web_contents, params);

bool GuestViewBase::ShouldFocusPageAfterCrash() {

// Focus is managed elsewhere.

return false;