Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 531893002: fyi: Remove buildrunner_tests from win_tests, switch chrome_elf_unittests to run without it. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cmp-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

fyi: Remove buildrunner_tests from win_tests, switch chrome_elf_unittests to run without it. buildrunner_tests apparently no longer works on windows (see e.g. crbug.com/409399), and only one test was using it anyways, so run that test normally. Also, while here, remove all --buildtool=ninja parameters, as that's the default these days. BUG=409404, 409399 (moved to https://codereview.chromium.org/536483002/)

Patch Set 1 #

Patch Set 2 : gen #

Patch Set 3 : base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 13 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
6 years, 3 months ago (2014-09-02 19:00:28 UTC) #2
Nico
(Eventually we probably want to switch to recipes.)
6 years, 3 months ago (2014-09-02 19:00:42 UTC) #3
Reid Kleckner
lgtm
6 years, 3 months ago (2014-09-02 19:54:15 UTC) #4
Nico
(i moved this to https://codereview.chromium.org/536483002/ since my .git/config still had a git-svn entry and hence ...
6 years, 3 months ago (2014-09-02 19:58:43 UTC) #7
Nico
…oh, maybe build is still on svn? http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.fyi/
6 years, 3 months ago (2014-09-02 20:00:29 UTC) #8
ghost stip (do not use)
6 years, 3 months ago (2014-09-02 20:07:09 UTC) #9
lgtm.

build is still on svn but it looks like the issue was uploaded correctly (base
URL is svn) so CQ should be able to land this

Powered by Google App Engine
This is Rietveld 408576698