Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 531823002: Properly initialize variables in RequestContentScript::ScriptData (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Properly initialize variables in RequestContentScript::ScriptData POD members of RequestContentScript::ScriptData weren't being initialized, which a) is really bad because who knows what they might have been, and b) is bad because it makes Dr. Memory unhappy. Fix it (and pull ScriptData into the .cc while we're at it). BUG=409865 Committed: https://crrev.com/08735d6ab39e788d287dc538f268f3c65d9c97c8 Cr-Commit-Position: refs/heads/master@{#292960}

Patch Set 1 #

Patch Set 2 : Also remove suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 1 chunk +13 lines, -1 line 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Jeffrey, can you take a quick look?
6 years, 3 months ago (2014-09-02 17:03:52 UTC) #2
Jeffrey Yasskin
lgtm
6 years, 3 months ago (2014-09-02 17:09:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/531823002/20001
6 years, 3 months ago (2014-09-02 17:16:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c653e60740e08c9e8485daeb78918ad8778c73ac
6 years, 3 months ago (2014-09-02 18:23:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08735d6ab39e788d287dc538f268f3c65d9c97c8
Cr-Commit-Position: refs/heads/master@{#292960}

Powered by Google App Engine
This is Rietveld 408576698