chrome/browser/extensions/api/declarative_content/content_action.cc - Issue 531823002: Properly initialize variables in RequestContentScript::ScriptData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action.cc

Issue 531823002: Properly initialize variables in RequestContentScript::ScriptData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also remove suppression Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_action.h ('k') | tools/valgrind/drmemory/suppressions_full.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_action.cc

diff --git a/chrome/browser/extensions/api/declarative_content/content_action.cc b/chrome/browser/extensions/api/declarative_content/content_action.cc

index b97a29f61237b89cd6bf84b47a790074587ba718..5fab9486acfeaba864ecfd6b41a09eaa4a5d0998 100644

--- a/chrome/browser/extensions/api/declarative_content/content_action.cc

+++ b/chrome/browser/extensions/api/declarative_content/content_action.cc

@@ -157,7 +157,19 @@ base::LazyInstance<ContentActionFactory>::Leaky

// RequestContentScript

-RequestContentScript::ScriptData::ScriptData() {}

+struct RequestContentScript::ScriptData {

+ ScriptData();

+ ~ScriptData();

+ std::vector<std::string> css_file_names;

+ std::vector<std::string> js_file_names;

+ bool all_frames;

+ bool match_about_blank;

+};

+RequestContentScript::ScriptData::ScriptData()

+ : all_frames(false),

+ match_about_blank(false) {}

RequestContentScript::ScriptData::~ScriptData() {}

// static