Fix windowed NPAPI plugins covering up dialogs on Win Aura.

Fix windowed NPAPI plugins covering up dialogs on Win Aura.

The original fix stopped working with the new style of dialogs, since they're not parented to the WebContents anymore but instead to its parent. It also turns out we don't need to watch out for transient windows, as they're now top level ones with their own HWND so clipping works through the OS and we don't need to do anything special.

BUG=299224
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233297

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233398

[Ben Goodger (Google), 2013-10-30 23:23:42]

https://codereview.chromium.org/53153003/diff/240001/content/browser/web_cont...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/53153003/diff/240001/content/browser/web_cont...
content/browser/web_contents/web_contents_view_aura.cc:678: // Constrained
windows are added as children of the parent's parent's view
I'm not sure you want to state this assumption so explicitly here... what if
another content embedder does something different?

[jam, 2013-10-31 00:07:04]

https://codereview.chromium.org/53153003/diff/240001/content/browser/web_cont...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/53153003/diff/240001/content/browser/web_cont...
content/browser/web_contents/web_contents_view_aura.cc:678: // Constrained
windows are added as children of the parent's parent's view
On 2013/10/30 23:23:43, Ben Goodger (Google) wrote:
> I'm not sure you want to state this assumption so explicitly here... what if
> another content embedder does something different?

yeah i realize this is a layering violation. ideally this code would be out of
content now. i can take a closer look about how much work that would be

[jam, 2013-11-06 02:03:42]

ptal, I added a browser test now to verify that the plugin is hidden by the
print preview

[Ben Goodger (Google), 2013-11-06 18:11:36]

lgtm

https://codereview.chromium.org/53153003/diff/940001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
(right):

https://codereview.chromium.org/53153003/diff/940001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc:90:
IN_PROC_BROWSER_TEST_F(PrintPreviewTest, WindowedNPAPIPluginHidden) {
I would add a comment here that this test is for the specific content behavior.
And a comment in content maybe to look for this test for that code.

[jam, 2013-11-06 18:15:20]

https://codereview.chromium.org/53153003/diff/940001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
(right):

https://codereview.chromium.org/53153003/diff/940001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc:90:
IN_PROC_BROWSER_TEST_F(PrintPreviewTest, WindowedNPAPIPluginHidden) {
On 2013/11/06 18:11:37, Ben Goodger (Google) wrote:
> I would add a comment here that this test is for the specific content
behavior.
> And a comment in content maybe to look for this test for that code.

Done.

[jam, 2013-11-06 22:29:38]

Ben FYI I've updated the test to handle the case when the browser window is
small enough that the print preview covers the plugin entirely. This can be
tried out manually by passing --window-size=640,480 to browser_tests. I'm now
relanding after a revert (one of the bots had a small window size).

[Ben Goodger (Google), 2013-11-07 00:27:43]

slgtm