Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 53153003: Fix windowed NPAPI plugins covering up dialogs on Win Aura. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix test with small browser size Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
===================================================================
--- content/browser/renderer_host/render_widget_host_view_aura.h (revision 233351)
+++ content/browser/renderer_host/render_widget_host_view_aura.h (working copy)
@@ -395,10 +395,6 @@
class WindowObserver;
friend class WindowObserver;
-#if defined(OS_WIN)
- class TransientWindowObserver;
- friend class TransientWindowObserver;
-#endif
// Overridden from ImageTransportFactoryObserver:
virtual void OnLostResources() OVERRIDE;
@@ -556,11 +552,6 @@
BrowserAccessibilityManager* GetOrCreateBrowserAccessibilityManager();
#if defined(OS_WIN)
- // Sets the cutout rects from transient windows. These are rectangles that
- // windowed NPAPI plugins shouldn't paint in. Overwrites any previous cutout
- // rects.
- void UpdateTransientRects(const std::vector<gfx::Rect>& rects);
-
// Updates the total list of cutout rects, which is the union of transient
// windows and constrained windows.
void UpdateCutoutRects();
@@ -731,11 +722,8 @@
PaintObserver* paint_observer_;
#if defined(OS_WIN)
- scoped_ptr<TransientWindowObserver> transient_observer_;
-
- // The list of rectangles from transient and constrained windows over this
- // view. Windowed NPAPI plugins shouldn't draw over them.
- std::vector<gfx::Rect> transient_rects_;
+ // The list of rectangles from constrained windows over this view. Windowed
+ // NPAPI plugins shouldn't draw over them.
std::vector<gfx::Rect> constrained_rects_;
typedef std::map<HWND, WebPluginGeometry> PluginWindowMoves;
« no previous file with comments | « chrome/test/data/printing/npapi_plugin.html ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698