Issue 531263002: Fix OEM menu issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 531263002: Fix OEM menu issue (Closed)

Created:
6 years, 3 months ago by David Trainor- moved to gerrit

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

Fix OEM menu issue - Some OEMs don't let us change the background, so the padding is incorrect. - Also including sizing the menu too large causes clipping. BUG=398837 Review URL: https://codereview.chromium.org/469673006 Cr-Commit-Position: refs/heads/master@{#291193} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291193 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 2b66232b8372c43968cc4b8cb0e9251098195d2f) Committed: https://chromium.googlesource.com/chromium/src/+/36e3f28deeb0a9f86cf03d7b3f9806920de17d03

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java	View		8 chunks	+24 lines, -11 lines	0 comments	Download

Total messages: 1 (0 generated)

David Trainor- moved to gerrit

6 years, 3 months ago (2014-09-02 22:46:04 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 36e3f28.