Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 469673006: Fix OEM menu issue (Closed)

Created:
6 years, 4 months ago by David Trainor- moved to gerrit
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix OEM menu issue - Some OEMs don't let us change the background, so the padding is incorrect. - Also including sizing the menu too large causes clipping. BUG=398837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291193

Patch Set 1 #

Patch Set 2 : Updated logic #

Patch Set 3 : Rebase, not ready yet though #

Patch Set 4 : More tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 2 3 8 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
David Trainor- moved to gerrit
6 years, 4 months ago (2014-08-15 22:19:49 UTC) #1
David Trainor- moved to gerrit
ptal. This seems to work... sigh. There's no best solution and it's not optimal (doesn't ...
6 years, 4 months ago (2014-08-20 22:37:03 UTC) #2
aurimas (slooooooooow)
LGTM... sigh...
6 years, 4 months ago (2014-08-20 22:39:48 UTC) #3
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 4 months ago (2014-08-20 22:59:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/469673006/60001
6 years, 4 months ago (2014-08-20 23:01:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 00:23:46 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 00:27:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55339) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8090)
6 years, 4 months ago (2014-08-21 00:27:36 UTC) #8
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 4 months ago (2014-08-21 19:44:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/469673006/60001
6 years, 4 months ago (2014-08-21 19:45:17 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:31:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (60001) as 291193

Powered by Google App Engine
This is Rietveld 408576698