Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: Source/core/events/MessageEvent.cpp

Issue 531183003: bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added FIXME comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/Event.idl ('k') | Source/core/events/MessageEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/MessageEvent.cpp
diff --git a/Source/core/events/MessageEvent.cpp b/Source/core/events/MessageEvent.cpp
index 1eb630a05bcf6fe2b549eb3c8f0518ec05ff2880..67465a1981fb995fef00b09090cf8fd3a33a43cf 100644
--- a/Source/core/events/MessageEvent.cpp
+++ b/Source/core/events/MessageEvent.cpp
@@ -199,6 +199,9 @@ v8::Handle<v8::Object> MessageEvent::wrap(v8::Handle<v8::Object> creationContext
{
v8::Handle<v8::Object> wrapper = Event::wrap(creationContext, isolate);
+ // Ensures a wrapper is created for the data to return now so that V8 knows how
+ // much memory is used via the wrapper. To keep the wrapper alive, it's set to
+ // the wrapper of the MessageEvent as a hidden value.
switch (dataType()) {
case MessageEvent::DataTypeScriptValue:
case MessageEvent::DataTypeSerializedScriptValue:
« no previous file with comments | « Source/core/events/Event.idl ('k') | Source/core/events/MessageEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698