Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: Source/core/events/MessageEvent.cpp

Issue 531183003: bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added FIXME comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/events/Event.idl ('k') | Source/core/events/MessageEvent.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Henry Mason (hmason@mac.com) 2 * Copyright (C) 2007 Henry Mason (hmason@mac.com)
3 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 #if ENABLE(OILPAN) 192 #if ENABLE(OILPAN)
193 visitor->trace(m_ports); 193 visitor->trace(m_ports);
194 #endif 194 #endif
195 Event::trace(visitor); 195 Event::trace(visitor);
196 } 196 }
197 197
198 v8::Handle<v8::Object> MessageEvent::wrap(v8::Handle<v8::Object> creationContext , v8::Isolate* isolate) 198 v8::Handle<v8::Object> MessageEvent::wrap(v8::Handle<v8::Object> creationContext , v8::Isolate* isolate)
199 { 199 {
200 v8::Handle<v8::Object> wrapper = Event::wrap(creationContext, isolate); 200 v8::Handle<v8::Object> wrapper = Event::wrap(creationContext, isolate);
201 201
202 // Ensures a wrapper is created for the data to return now so that V8 knows how
203 // much memory is used via the wrapper. To keep the wrapper alive, it's set to
204 // the wrapper of the MessageEvent as a hidden value.
202 switch (dataType()) { 205 switch (dataType()) {
203 case MessageEvent::DataTypeScriptValue: 206 case MessageEvent::DataTypeScriptValue:
204 case MessageEvent::DataTypeSerializedScriptValue: 207 case MessageEvent::DataTypeSerializedScriptValue:
205 break; 208 break;
206 case MessageEvent::DataTypeString: 209 case MessageEvent::DataTypeString:
207 V8HiddenValue::setHiddenValue(isolate, wrapper, V8HiddenValue::stringDat a(isolate), v8String(isolate, dataAsString())); 210 V8HiddenValue::setHiddenValue(isolate, wrapper, V8HiddenValue::stringDat a(isolate), v8String(isolate, dataAsString()));
208 break; 211 break;
209 case MessageEvent::DataTypeBlob: 212 case MessageEvent::DataTypeBlob:
210 break; 213 break;
211 case MessageEvent::DataTypeArrayBuffer: 214 case MessageEvent::DataTypeArrayBuffer:
212 V8HiddenValue::setHiddenValue(isolate, wrapper, V8HiddenValue::arrayBuff erData(isolate), toV8(dataAsArrayBuffer(), wrapper, isolate)); 215 V8HiddenValue::setHiddenValue(isolate, wrapper, V8HiddenValue::arrayBuff erData(isolate), toV8(dataAsArrayBuffer(), wrapper, isolate));
213 break; 216 break;
214 } 217 }
215 218
216 return wrapper; 219 return wrapper;
217 } 220 }
218 221
219 } // namespace blink 222 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/events/Event.idl ('k') | Source/core/events/MessageEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698