Issue 531023002: Revert of Disable NEON procs for box blur as it produces invalid results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 531023002: Revert of Disable NEON procs for box blur as it produces invalid results (Closed)

Created:
6 years, 3 months ago by djsollen

Modified:
6 years, 3 months ago

Reviewers:
mtklein, senorblanco

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Disable NEON procs for box blur as it produces invalid results (patchset #1 id:1 of https://codereview.chromium.org/520963002/) Reason for revert: failing more GMs than expected. Original issue's description: > Disable NEON procs for box blur as it produces invalid results > > BUG=skia:2845 > > Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99 TBR=senorblanco@google.com,mtklein@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2845 Committed: https://skia.googlesource.com/skia/+/4d6484e764ef8d38efc841e74922d61360ff8667

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	src/opts/SkBlurImage_opts_arm.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

djsollen

Created Revert of Disable NEON procs for box blur as it produces invalid results

6 years, 3 months ago (2014-09-02 13:31:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/531023002/1

6 years, 3 months ago (2014-09-02 13:32:23 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-02 13:32:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 4d6484e764ef8d38efc841e74922d61360ff8667