src/opts/SkBlurImage_opts_arm.cpp - Issue 531023002: Revert of Disable NEON procs for box blur as it produces invalid results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/opts/SkBlurImage_opts_arm.cpp

Issue 531023002: Revert of Disable NEON procs for box blur as it produces invalid results (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/opts/SkBlurImage_opts_arm.cpp

diff --git a/src/opts/SkBlurImage_opts_arm.cpp b/src/opts/SkBlurImage_opts_arm.cpp

index fb6103482ccfdcd2e46579e3c7c4020539b65098..7462e6fb7daab6c18363ed1f0fa65a70e62195e7 100644

--- a/src/opts/SkBlurImage_opts_arm.cpp

+++ b/src/opts/SkBlurImage_opts_arm.cpp

@@ -12,11 +12,10 @@

SkBoxBlurProc* boxBlurY,

SkBoxBlurProc* boxBlurXY,

SkBoxBlurProc* boxBlurYX) {

- // Temporary workaround for http://skbug.com/2845

- return false;

#if SK_ARM_NEON_IS_NONE

return false;

+#elif defined(SK_CPU_ARM64) // Temporary fix for

+ return false; // http://skbug.com/2845

#else

#if SK_ARM_NEON_IS_DYNAMIC

if (!sk_cpu_arm_has_neon()) {

« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | no next file » | no next file with comments »