Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 530973002: Lower simplified StringAdd to stub call. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Lower simplified StringAdd to stub call. R=titzer@chromium.org TEST=cctest/test-simplified-lowering/LowerStringOps_to_calls Committed: https://code.google.com/p/v8/source/detail?r=23610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +14 lines, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-02 08:44:35 UTC) #1
titzer
lgtm
6 years, 3 months ago (2014-09-02 12:28:27 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-02 12:46:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698