src/compiler/js-typed-lowering.cc - Issue 530973002: Lower simplified StringAdd to stub call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 530973002: Lower simplified StringAdd to stub call. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 0cf53373f637645ce74f73cdd5a367e23c495d08..6fad5ab6033527d76d069295c7c7c8e81f95dc1f 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -222,7 +222,8 @@ Reduction JSTypedLowering::ReduceJSAdd(Node* node) {

if (r.OneInputIs(Type::String())) {

r.ConvertInputsToString();

return r.ChangeToPureOperator(simplified()->StringAdd());

- } else if (r.NeitherInputCanBe(Type::String())) {

+ }

+ if (r.NeitherInputCanBe(Type::String())) {

r.ConvertInputsToNumber();

return r.ChangeToPureOperator(simplified()->NumberAdd());

}

« no previous file with comments | « no previous file | src/compiler/simplified-lowering.h » ('j') | no next file with comments »