Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 530213004: Use XMPP in V2 webapp (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 11 months ago
Reviewers:
Jamie, Wez, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use XMPP in V2 webapp After this change the webapp will be use XMPP for signaling instead of WCS. BUG=274652 Committed: https://crrev.com/30975b8951c8c131883b0da0944b130fc8d1f2ae Cr-Commit-Position: refs/heads/master@{#293273}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -140 lines) Patch
M remoting/client/plugin/delegating_signal_strategy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/delegating_signal_strategy.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
M remoting/webapp/client_session.js View 1 2 8 chunks +44 lines, -66 lines 0 comments Download
M remoting/webapp/session_connector.js View 1 2 8 chunks +78 lines, -12 lines 0 comments Download
A remoting/webapp/signal_strategy.js View 1 chunk +67 lines, -0 lines 0 comments Download
M remoting/webapp/unittests/xmpp_connection_unittest.js View 1 5 chunks +6 lines, -5 lines 0 comments Download
A remoting/webapp/wcs_adapter.js View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
M remoting/webapp/xmpp_connection.js View 14 chunks +42 lines, -43 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-03 00:18:58 UTC) #5
Wez
Does this patch support re-establishing a dropped XMPP session without changing the JID?
6 years, 3 months ago (2014-09-03 01:05:33 UTC) #8
Sergey Ulanov
On 2014/09/03 01:05:33, Wez wrote: > Does this patch support re-establishing a dropped XMPP session ...
6 years, 3 months ago (2014-09-03 01:25:55 UTC) #9
kelvinp
lgtm with style nits. https://codereview.chromium.org/530213004/diff/100001/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/530213004/diff/100001/remoting/webapp/client_session.js#newcode872 remoting/webapp/client_session.js:872: /** @param{Element} message */ Nit ...
6 years, 3 months ago (2014-09-03 18:53:30 UTC) #10
Sergey Ulanov
https://codereview.chromium.org/530213004/diff/100001/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/530213004/diff/100001/remoting/webapp/client_session.js#newcode872 remoting/webapp/client_session.js:872: /** @param{Element} message */ On 2014/09/03 18:53:29, kelvinp wrote: ...
6 years, 3 months ago (2014-09-03 23:25:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/530213004/120001
6 years, 3 months ago (2014-09-03 23:28:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1894)
6 years, 3 months ago (2014-09-04 02:30:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/530213004/120001
6 years, 3 months ago (2014-09-04 04:23:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9878)
6 years, 3 months ago (2014-09-04 05:44:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/530213004/120001
6 years, 3 months ago (2014-09-04 05:50:08 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:120001) as 6f55b20cc5216bf8d14364ea4706eba0c0cbc8fb
6 years, 3 months ago (2014-09-04 06:38:21 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:23 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30975b8951c8c131883b0da0944b130fc8d1f2ae
Cr-Commit-Position: refs/heads/master@{#293273}

Powered by Google App Engine
This is Rietveld 408576698