Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 530113002: Refresh the avatar bubble with the current view (Closed)

Created:
6 years, 3 months ago by guohui
Modified:
6 years, 3 months ago
Reviewers:
noms (inactive), sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refresh the avatar bubble with the current view The new avatar menu has multiple views, and on any view, the avatar menu change event may occur and trigger refresh. Thus instead of always refreshing with the profile chooser view mode, we should refresh with the current view mode. BUG= Committed: https://crrev.com/798b02e5493df49c821eb2b11e326b1424ef29fc Cr-Commit-Position: refs/heads/master@{#293123}

Patch Set 1 #

Patch Set 2 : only refresh if necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 3 months ago (2014-09-02 18:16:00 UTC) #2
noms (inactive)
lgtm
6 years, 3 months ago (2014-09-02 18:18:40 UTC) #3
sky
LGTM
6 years, 3 months ago (2014-09-02 21:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/530113002/20001
6 years, 3 months ago (2014-09-02 21:44:41 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-03 00:01:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/530113002/20001
6 years, 3 months ago (2014-09-03 11:52:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0f02ad079d2ec44c81793563445d1195ec77d5ce
6 years, 3 months ago (2014-09-03 11:53:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/798b02e5493df49c821eb2b11e326b1424ef29fc
Cr-Commit-Position: refs/heads/master@{#293123}

Powered by Google App Engine
This is Rietveld 408576698