Issue 5301004: Add firmware build mode to Makefiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5301004: Add firmware build mode to Makefiles (Closed)

Created:
10 years ago by Che-Liang Chiou

Modified:
9 years ago

Reviewers:
Randall Spangler, anush

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Add firmware build mode to Makefiles This CL also includes a biosincludes.h for ARM platform. The changes to ebuilds are in a separated CL:5352002. BUG=None TEST=Run 'make' and 'make FIRMWARE_ARCH=arm' successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0a0e8d0

Patch Set 1 #

Patch Set 2 : Add arch/ into in README #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -3 lines)			Patch
M	Makefile	View	3 chunks	+17 lines, -1 line	0 comments	Download
M	firmware/Makefile	View	2 chunks	+13 lines, -2 lines	0 comments	Download
M	firmware/README	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	firmware/arch/arm/include/biosincludes.h	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Che-Liang Chiou

Randall: Makefile changes & biosincludes.h Anush: For your reference

10 years ago (2010-11-25 08:09:22 UTC) #2

LGTM, thanks

Expand Messages | Collapse Messages