Use IsRenderViewLive() to test for SadTab in ZoomController.

Use IsRenderViewLive() to test for SadTab in ZoomController.

In a previous attempt to prevent SadTab pages from being zoomable we
attempted to use RenderProcessHost::HasConnection, but this fails in
the case where a new tab can be started in the same RenderProcessHost
while the SadTab is still visible. This CL switches to testing to see
if the RenderView for the tab in question is live in order to avoid
this problem.

BUG=407562
Committed: https://crrev.com/5eeba9136acc2d74d7065249c4359d752b9258dd
Cr-Commit-Position: refs/heads/master@{#292988}

[wjmaclean, 2014-09-02 14:24:17]

wjmaclean@chromium.org changed reviewers:
+ fsamuel@chromium.org

[wjmaclean, 2014-09-02 14:24:48]

A short CL to change the SadTab test used in ZoomController.

[Fady Samuel, 2014-09-02 14:27:24]

lgtm with nit.

https://codereview.chromium.org/529993002/diff/1/chrome/browser/ui/zoom/zoom_...
File chrome/browser/ui/zoom/zoom_controller.cc (right):

https://codereview.chromium.org/529993002/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.cc:96:
!web_contents()->GetRenderViewHost()->IsRenderViewLive())
nit: indentation is off

[wjmaclean, 2014-09-02 14:42:55]

Patch for landing.

https://codereview.chromium.org/529993002/diff/1/chrome/browser/ui/zoom/zoom_...
File chrome/browser/ui/zoom/zoom_controller.cc (right):

https://codereview.chromium.org/529993002/diff/1/chrome/browser/ui/zoom/zoom_...
chrome/browser/ui/zoom/zoom_controller.cc:96:
!web_contents()->GetRenderViewHost()->IsRenderViewLive())
On 2014/09/02 14:27:24, Fady Samuel wrote:
> nit: indentation is off

Done.

[wjmaclean, 2014-09-02 14:43:16]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2014-09-02 14:44:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/529993002/20001

[commit-bot: I haz the power, 2014-09-02 15:02:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49043)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54365)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-09-02 15:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:05:50]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49053)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wjmaclean, 2014-09-02 15:06:55]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:08:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/529993002/40001

[commit-bot: I haz the power, 2014-09-02 20:27:55]

Committed patchset #3 (id:40001) as ca492c1b66388d6bae3f4ee5ddb9e2270be4e71d

[commit-bot: I haz the power, 2014-09-10 03:20:28]

Patchset 3 (id:??) landed as
https://crrev.com/5eeba9136acc2d74d7065249c4359d752b9258dd
Cr-Commit-Position: refs/heads/master@{#292988}