chrome/browser/ui/zoom/zoom_controller_browsertest.cc - Issue 529993002: Use IsRenderViewLive() to test for SadTab in ZoomController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 529993002: Use IsRenderViewLive() to test for SadTab in ZoomController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to r292920. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

diff --git a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

index 73372bb7a99a5b33bd2e5a4a387b581e422a1e4a..1fcd782a8a3f551f2c4b6447bb55041b1e4f7250 100644

--- a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

+++ b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

@@ -13,6 +13,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/public/browser/render_process_host.h"

+#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/browser_test_utils.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -81,7 +82,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,

base::KillProcess(host->GetHandle(), 0, false);

crash_observer.Wait();

}

- EXPECT_FALSE(web_contents->GetRenderProcessHost()->HasConnection());

+ EXPECT_FALSE(web_contents->GetRenderViewHost()->IsRenderViewLive());

// The following attempt to change the zoom level for a crashed tab should

// fail.

« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller.cc ('k') | chrome/browser/ui/zoom/zoom_controller_unittest.cc » ('j') | no next file with comments »