Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 529293002: Fix DesktopMediaPickerViews to handle background parent_web_contents (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Fix DesktopMediaPickerViews to handle background parent_web_contents After r283702 DesktopMediaPickerViews is getting parent_web_contents even when it corresponds to a background extension page. DesktopMediaPickerViews was always trying to create a modal dialog when web_contents is specified, and that doesn't work for background pages. Now it explicitly checks if the web_contents is a background page and in that case shows the picker in a separate window. Also updated example for desktop capture API to make it easier to test this scenario. BUG=402579 Review URL: https://codereview.chromium.org/501713002 Cr-Commit-Position: refs/heads/master@{#292055} TBR=sergeyu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fa2d62218b6c77a6bcd025e7055a609ddb8899bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M chrome/browser/ui/views/desktop_media_picker_views.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/background.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/index.html View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-03 02:01:10 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as fa2d622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698