Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 501713002: Fix DesktopMediaPickerViews to handle background parent_web_contents (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
scheib, Wez, msw
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix DesktopMediaPickerViews to handle background parent_web_contents After r283702 DesktopMediaPickerViews is getting parent_web_contents even when it corresponds to a background extension page. DesktopMediaPickerViews was always trying to create a modal dialog when web_contents is specified, and that doesn't work for background pages. Now it explicitly checks if the web_contents is a background page and in that case shows the picker in a separate window. Also updated example for desktop capture API to make it easier to test this scenario. BUG=402579 Committed: https://crrev.com/71b32fcc875526596305a98c1a1194e690dc8719 Cr-Commit-Position: refs/heads/master@{#292055}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M chrome/browser/ui/views/desktop_media_picker_views.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 2 3 4 5 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/app.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/background.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/desktopCapture/index.html View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 28 (0 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-23 01:16:58 UTC) #1
Wez
https://codereview.chromium.org/501713002/diff/20001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/20001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode415 chrome/browser/ui/views/desktop_media_picker_views.cc:415: bool modal_dialog = nit: Suggest has_visible_parent https://codereview.chromium.org/501713002/diff/20001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode421 chrome/browser/ui/views/desktop_media_picker_views.cc:421: widget ...
6 years, 4 months ago (2014-08-23 21:51:21 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/501713002/diff/20001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/20001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode415 chrome/browser/ui/views/desktop_media_picker_views.cc:415: bool modal_dialog = On 2014/08/23 21:51:21, Wez wrote: > ...
6 years, 4 months ago (2014-08-25 17:07:46 UTC) #3
Wez
lgtm https://codereview.chromium.org/501713002/diff/40001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/40001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode425 chrome/browser/ui/views/desktop_media_picker_views.cc:425: // the picker window from the list of ...
6 years, 4 months ago (2014-08-25 21:32:02 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/501713002/diff/40001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/40001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode425 chrome/browser/ui/views/desktop_media_picker_views.cc:425: // the picker window from the list of available ...
6 years, 4 months ago (2014-08-25 22:03:52 UTC) #5
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-25 22:04:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/501713002/60001
6 years, 4 months ago (2014-08-25 22:06:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-26 01:54:33 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:58:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6561)
6 years, 4 months ago (2014-08-26 01:58:35 UTC) #10
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 3 months ago (2014-08-26 06:07:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/501713002/80001
6 years, 3 months ago (2014-08-26 06:08:15 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 07:05:42 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 07:09:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6622)
6 years, 3 months ago (2014-08-26 07:09:54 UTC) #15
Sergey Ulanov
sergeyu@chromium.org changed reviewers: + msw@chromium.org, scheib@chromium.org
6 years, 3 months ago (2014-08-26 21:51:38 UTC) #16
Sergey Ulanov
Need OWNERS approvals: scheib@ - chrome/common/extensions/docs/ msw@ - chrome/browser/ui/views/
6 years, 3 months ago (2014-08-26 21:51:38 UTC) #17
msw
https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode385 chrome/browser/ui/views/desktop_media_picker_views.cc:385: gfx::NativeWindow parent_window, |parent_window| is no longer used, remove it ...
6 years, 3 months ago (2014-08-26 22:16:46 UTC) #18
Sergey Ulanov
https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode385 chrome/browser/ui/views/desktop_media_picker_views.cc:385: gfx::NativeWindow parent_window, On 2014/08/26 22:16:46, msw wrote: > |parent_window| ...
6 years, 3 months ago (2014-08-26 22:43:11 UTC) #19
msw
chrome/browser/ui/views/ lgtm https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc File chrome/browser/ui/views/desktop_media_picker_views.cc (right): https://codereview.chromium.org/501713002/diff/80001/chrome/browser/ui/views/desktop_media_picker_views.cc#newcode385 chrome/browser/ui/views/desktop_media_picker_views.cc:385: gfx::NativeWindow parent_window, On 2014/08/26 22:43:11, Sergey Ulanov ...
6 years, 3 months ago (2014-08-26 23:03:16 UTC) #20
scheib
chrome/common/extensions/docs/ LGTM
6 years, 3 months ago (2014-08-26 23:05:04 UTC) #21
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 3 months ago (2014-08-26 23:12:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/501713002/100001
6 years, 3 months ago (2014-08-26 23:13:23 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 00:15:23 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (100001) as 21dca3d092473cbeef024f4788926c46f63c2f58
6 years, 3 months ago (2014-08-27 00:33:30 UTC) #25
thembrown
Sorry for posting here, I don't have access to the Bug. Is there any change ...
6 years, 3 months ago (2014-09-05 09:00:05 UTC) #26
Sergey Ulanov
Yes, it's already merged to the M38 branch. On Fri, Sep 5, 2014 at 2:00 ...
6 years, 3 months ago (2014-09-05 17:26:27 UTC) #27
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:15 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/71b32fcc875526596305a98c1a1194e690dc8719
Cr-Commit-Position: refs/heads/master@{#292055}

Powered by Google App Engine
This is Rietveld 408576698