Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 529273002: Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui… (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, jbauman+watch_chromium.org, jshin+watch_chromium.org, kalyank, kinuko+fileapi, nhiroki, ozone-reviews_chromium.org, piman+watch_chromium.org, rjkroege, sievers+watch_chromium.org, tzik, Ian Vollick, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui, and webkit. TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org Committed: https://crrev.com/22dfc40185c63bd1278792fe422bd82c63ff6213 Cr-Commit-Position: refs/heads/master@{#293479}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -67 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M gin/modules/file_module_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/shell/gin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/shell/gin_shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/test/file.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/test/file_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/test/run_js_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_cups.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/recovery_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/sqlite_features_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/statement_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/test/paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/test/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/data_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/data_pack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_profile_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gfx_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/test/fontconfig_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/test/test_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/vfs_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dragged_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dump_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_prioritized_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Lei Zhang
6 years, 3 months ago (2014-09-03 22:25:14 UTC) #2
tfarina
lgtm https://codereview.chromium.org/529273002/diff/1/ui/gfx/color_profile_win.cc File ui/gfx/color_profile_win.cc (right): https://codereview.chromium.org/529273002/diff/1/ui/gfx/color_profile_win.cc#newcode7 ui/gfx/color_profile_win.cc:7: #include <windows.h> this is probably fine, since it ...
6 years, 3 months ago (2014-09-04 18:08:11 UTC) #4
brettw
rs lgtm
6 years, 3 months ago (2014-09-04 21:02:23 UTC) #5
Lei Zhang
TBR: ben: ui/ jamesr: webkit/ jochen: PRESUBMIT.py and gin/ rogerta: google_apis/ shess: sql/
6 years, 3 months ago (2014-09-05 06:28:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/529273002/20001
6 years, 3 months ago (2014-09-05 06:30:03 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-05 08:23:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8e2dacd6feaeafa86e3308630887f140764056b9
6 years, 3 months ago (2014-09-05 08:30:43 UTC) #11
Scott Hess - ex-Googler
lgtm
6 years, 3 months ago (2014-09-08 04:18:25 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22dfc40185c63bd1278792fe422bd82c63ff6213
Cr-Commit-Position: refs/heads/master@{#293479}

Powered by Google App Engine
This is Rietveld 408576698