Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: PRESUBMIT.py

Issue 529273002: Change base/file_utils.h includes to base/files/file_utils.h in gin, google_apis, printing, sql, ui… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gin/modules/file_module_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 918 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 r"^chromecast[\\\/]", 929 r"^chromecast[\\\/]",
930 r"^cloud_print[\\\/]", 930 r"^cloud_print[\\\/]",
931 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" 931 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]"
932 r"gl_helper_benchmark\.cc$", 932 r"gl_helper_benchmark\.cc$",
933 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", 933 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$",
934 r"^native_client_sdk[\\\/]", 934 r"^native_client_sdk[\\\/]",
935 r"^remoting[\\\/]base[\\\/]logging\.h$", 935 r"^remoting[\\\/]base[\\\/]logging\.h$",
936 r"^remoting[\\\/]host[\\\/].*", 936 r"^remoting[\\\/]host[\\\/].*",
937 r"^sandbox[\\\/]linux[\\\/].*", 937 r"^sandbox[\\\/]linux[\\\/].*",
938 r"^tools[\\\/]", 938 r"^tools[\\\/]",
939 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",)) 939 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",
940 r"^webkit[\\\/]browser[\\\/]fileapi[\\\/]" +
941 r"dump_file_system.cc$",))
940 source_file_filter = lambda x: input_api.FilterSourceFile( 942 source_file_filter = lambda x: input_api.FilterSourceFile(
941 x, white_list=(file_inclusion_pattern,), black_list=black_list) 943 x, white_list=(file_inclusion_pattern,), black_list=black_list)
942 944
943 log_info = [] 945 log_info = []
944 printf = [] 946 printf = []
945 947
946 for f in input_api.AffectedSourceFiles(source_file_filter): 948 for f in input_api.AffectedSourceFiles(source_file_filter):
947 contents = input_api.ReadFile(f, 'rb') 949 contents = input_api.ReadFile(f, 'rb')
948 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): 950 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents):
949 log_info.append(f.LocalPath()) 951 log_info.append(f.LocalPath())
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
1585 builders.extend(['cros_x86']) 1587 builders.extend(['cros_x86'])
1586 1588
1587 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1589 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1588 # unless they're .gyp(i) files as changes to those files can break the gyp 1590 # unless they're .gyp(i) files as changes to those files can break the gyp
1589 # step on that bot. 1591 # step on that bot.
1590 if (not all(re.search('^chrome', f) for f in files) or 1592 if (not all(re.search('^chrome', f) for f in files) or
1591 any(re.search('\.gypi?$', f) for f in files)): 1593 any(re.search('\.gypi?$', f) for f in files)):
1592 builders.extend(['android_aosp']) 1594 builders.extend(['android_aosp'])
1593 1595
1594 return GetDefaultTryConfigs(builders) 1596 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | gin/modules/file_module_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698