Issue 529023002: Fixing GestureNav on HDPI displays - merge into M38.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 529023002: Fixing GestureNav on HDPI displays - merge into M38. (Closed)

Created:
6 years, 3 months ago by mfomitchev

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

Fixing GestureNav on HDPI displays. The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136 Thus we don't need to scale it again when we paint during the overscroll gesture. BUG=402280 TBR=sky Review URL: https://codereview.chromium.org/507083002 Cr-Commit-Position: refs/heads/master@{#292426} (cherry picked from commit 7aa72c87b03a58c50ea88cc000dda7bb16a8edff) Committed: https://chromium.googlesource.com/chromium/src/+/e772e6be07696d4f7795a318c6d96e29ca1ef337

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	content/browser/web_contents/aura/overscroll_navigation_overlay.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	content/browser/web_contents/web_contents_view_aura.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

mfomitchev

6 years, 3 months ago (2014-09-02 15:18:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as e772e6b (presubmit successful).