Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 507083002: Fixing GestureNav on HDPI displays. (Closed)

Created:
6 years, 3 months ago by mfomitchev
Modified:
6 years, 3 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, miu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixing GestureNav on HDPI displays. The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136 Thus we don't need to scale it again when we paint during the overscroll gesture. BUG=402280 Committed: https://crrev.com/7aa72c87b03a58c50ea88cc000dda7bb16a8edff Cr-Commit-Position: refs/heads/master@{#292426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mfomitchev
mfomitchev@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-26 21:33:58 UTC) #1
mfomitchev
@sadrul, can you please take the first look?
6 years, 3 months ago (2014-08-26 21:33:58 UTC) #2
sadrul
Has there been a recent change related to this? It used to work correctly on ...
6 years, 3 months ago (2014-08-27 01:54:51 UTC) #3
mfomitchev1
On 2014/08/27 01:54:51, sadrul wrote: > Has there been a recent change related to this? ...
6 years, 3 months ago (2014-08-27 02:04:12 UTC) #4
mfomitchev
I tested this on M37, and it appears the scale factor there is reported to ...
6 years, 3 months ago (2014-08-27 15:58:44 UTC) #5
mfomitchev
mfomitchev@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-27 18:18:17 UTC) #6
mfomitchev
+sky@ (might want to bring this into M38)
6 years, 3 months ago (2014-08-27 18:18:18 UTC) #7
sky
LGTM - but wait for Sadrul to be happy too.
6 years, 3 months ago (2014-08-27 20:23:08 UTC) #8
sadrul
LGTM Perhaps this was caused by https://codereview.chromium.org/462173002 / https://codereview.chromium.org/461443003
6 years, 3 months ago (2014-08-28 13:20:05 UTC) #9
mfomitchev
The CQ bit was checked by mfomitchev@chromium.org
6 years, 3 months ago (2014-08-28 14:07:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/507083002/1
6 years, 3 months ago (2014-08-28 14:08:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as ef0c752fb7189143ca4bac13bf82b1b0da27ea59
6 years, 3 months ago (2014-08-28 18:46:11 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aa72c87b03a58c50ea88cc000dda7bb16a8edff
Cr-Commit-Position: refs/heads/master@{#292426}

Powered by Google App Engine
This is Rietveld 408576698