Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 528963003: [Android] Add missing @VisibleForTesting annotations. (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
Ted C, nyquist, brettw
CC:
chromium-reviews, tim+watch_chromium.org, David Trainor- moved to gerrit, jam, zea+watch_chromium.org, avayvod+watch_chromium.org, haitaol+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Add missing @VisibleForTesting annotations. Proguard strips these methods if they are not annotated because they are only used in tests. TBR=brettw BUG=163393 Committed: https://crrev.com/a5f8ead45f469cb046403b250272b855de9fbba3 Cr-Commit-Position: refs/heads/master@{#293009}

Patch Set 1 #

Patch Set 2 : Fix GN build #

Messages

Total messages: 18 (5 generated)
aurimas (slooooooooow)
Hey Tommy, PTAL at this CL. Thanks! Aurimas
6 years, 3 months ago (2014-09-02 16:29:35 UTC) #2
nyquist
lgtm Could you also update your description to say @VisibleForTesting instead of @VisibleByTesting?
6 years, 3 months ago (2014-09-02 17:32:06 UTC) #3
nyquist
Also, as a side note, it seemed odd to me that a lot of these ...
6 years, 3 months ago (2014-09-02 17:33:07 UTC) #4
aurimas (slooooooooow)
tedchoc@chromium.org: Please review changes in ContentViewCore.java
6 years, 3 months ago (2014-09-02 17:33:34 UTC) #6
Ted C
lgtm
6 years, 3 months ago (2014-09-02 17:35:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/528963003/1
6 years, 3 months ago (2014-09-02 17:37:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-02 18:36:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/11544)
6 years, 3 months ago (2014-09-02 18:42:31 UTC) #11
aurimas (slooooooooow)
brettw@chromium.org: Please review changes in base/BUILD.gn
6 years, 3 months ago (2014-09-02 18:45:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/528963003/20001
6 years, 3 months ago (2014-09-02 21:09:36 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 22:08:28 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b66edd01739193e6cff691361466e50a646adcb5
6 years, 3 months ago (2014-09-02 22:23:00 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5f8ead45f469cb046403b250272b855de9fbba3
Cr-Commit-Position: refs/heads/master@{#293009}

Powered by Google App Engine
This is Rietveld 408576698