Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 528963003: [Android] Add missing @VisibleForTesting annotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 3ec2b64131af0c944ec2ca6536435588aae78310..f61b371bed573ae8e7aa5533e1568816e7c476a7 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -47,8 +47,6 @@ import android.view.inputmethod.InputConnection;
import android.view.inputmethod.InputMethodManager;
import android.widget.FrameLayout;
-import com.google.common.annotations.VisibleForTesting;
-
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.CalledByNative;
import org.chromium.base.CommandLine;
@@ -56,6 +54,7 @@ import org.chromium.base.JNINamespace;
import org.chromium.base.ObserverList;
import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.TraceEvent;
+import org.chromium.base.VisibleForTesting;
import org.chromium.content.R;
import org.chromium.content.browser.ScreenOrientationListener.ScreenOrientationObserver;
import org.chromium.content.browser.accessibility.AccessibilityInjector;
@@ -947,7 +946,9 @@ public class ContentViewCore
public int getPhysicalBackingHeightPix() { return mPhysicalBackingHeightPix; }
/* TODO(aelias): Remove these when downstream callers disappear. */
+ @VisibleForTesting
public int getViewportSizeOffsetWidthPix() { return 0; }
+ @VisibleForTesting
public int getViewportSizeOffsetHeightPix() { return getTopControlsLayoutHeightPix(); }
/**
@@ -1000,6 +1001,7 @@ public class ContentViewCore
* of bounds.
* @param offset The offset into the navigation history.
*/
+ @VisibleForTesting
public void goToOffset(int offset) {
if (mWebContents != null) mWebContents.getNavigationController().goToOffset(offset);
}
@@ -1419,6 +1421,7 @@ public class ContentViewCore
* @return The ID of the renderer process that backs this tab or
* {@link #INVALID_RENDER_PROCESS_PID} if there is none.
*/
+ @VisibleForTesting
public int getCurrentRenderProcessId() {
return nativeGetCurrentRenderProcessId(mNativeContentViewCore);
}
@@ -2383,14 +2386,17 @@ public class ContentViewCore
private PopupTouchHandleDrawable createPopupTouchHandleDrawable() {
if (mTouchHandleDelegate == null) {
mTouchHandleDelegate = new PopupTouchHandleDrawableDelegate() {
+ @Override
public View getParent() {
return getContainerView();
}
+ @Override
public PositionObserver getParentPositionObserver() {
return mPositionObserver;
}
+ @Override
public boolean onTouchHandleEvent(MotionEvent event) {
final boolean isTouchHandleEvent = true;
return onTouchEventImpl(event, isTouchHandleEvent);
@@ -2430,6 +2436,7 @@ public class ContentViewCore
if (mPastePopupMenu == null) {
mPastePopupMenu = new PastePopupMenu(getContainerView(),
new PastePopupMenuDelegate() {
+ @Override
public void paste() {
mImeAdapter.paste();
hideTextHandles();
@@ -2673,6 +2680,7 @@ public class ContentViewCore
* Return the current scale of the ContentView.
* @return The current page scale factor.
*/
+ @VisibleForTesting
public float getScale() {
return mRenderCoordinates.getPageScaleFactor();
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698