Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 528783002: Change MediaStreamVideoSource::StartSourceImpl to use VideoCaptureFormat instead of VideoCapturePar… (Closed)

Created:
6 years, 3 months ago by perkj_chrome
Modified:
6 years, 3 months ago
Reviewers:
mcasas, magjed_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change MediaStreamVideoSource::StartSourceImpl to use VideoCaptureFormat instead of VideoCaptureParams. MediaStreamVideoSource only need the VideoCaptureFormat and thus should not pass VideoCaptureParams to its implementations. This just a small code cleanup and does not change any behaviour. TBR=bbudge@chromium.org Committed: https://crrev.com/b8acb852d96513eb8d0715dbea11d8455ea42522 Cr-Commit-Position: refs/heads/master@{#293924}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M content/renderer/media/media_stream_video_capturer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capturer_source.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_source.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_source.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
perkj_chrome
Can you please review?
6 years, 3 months ago (2014-09-01 14:32:40 UTC) #2
magjed_chromium
lgtm
6 years, 3 months ago (2014-09-02 15:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/528783002/1
6 years, 3 months ago (2014-09-03 11:08:55 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-03 11:08:57 UTC) #7
mcasas
LGTM you might still need content/renderer/pepper approval though.
6 years, 3 months ago (2014-09-05 11:58:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/528783002/1
6 years, 3 months ago (2014-09-05 11:59:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/63133) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/52122) win_gpu ...
6 years, 3 months ago (2014-09-05 12:08:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/528783002/20001
6 years, 3 months ago (2014-09-09 11:17:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9607)
6 years, 3 months ago (2014-09-09 11:24:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/528783002/20001
6 years, 3 months ago (2014-09-09 11:45:12 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c725705556eb9f377f27d3332cbbb623fbaff481
6 years, 3 months ago (2014-09-09 12:17:56 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:55 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8acb852d96513eb8d0715dbea11d8455ea42522
Cr-Commit-Position: refs/heads/master@{#293924}

Powered by Google App Engine
This is Rietveld 408576698