content/renderer/media/media_stream_video_source.h - Issue 528783002: Change MediaStreamVideoSource::StartSourceImpl to use VideoCaptureFormat instead of VideoCapturePar…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_source.h

Issue 528783002: Change MediaStreamVideoSource::StartSourceImpl to use VideoCaptureFormat instead of VideoCapturePar… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_video_capturer_source.cc ('k') | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_source.h

diff --git a/content/renderer/media/media_stream_video_source.h b/content/renderer/media/media_stream_video_source.h

index e75141384e873c04b2f79b4754bc05799443566c..d1ceeefa66323e87c91a3759ae78596a82ad6770 100644

--- a/content/renderer/media/media_stream_video_source.h

+++ b/content/renderer/media/media_stream_video_source.h

@@ -107,11 +107,9 @@ class CONTENT_EXPORT MediaStreamVideoSource

// An implementation must start capture frames using the resolution in

// |params|. When the source has started or the source failed to start

// OnStartDone must be called. An implementation must call

- // invoke |frame_callback| on the IO thread with the captured frames.

- // TODO(perkj): pass a VideoCaptureFormats instead of VideoCaptureParams for

- // subclasses to customize.

+ // |frame_callback| on the IO thread with the captured frames.

virtual void StartSourceImpl(

- const media::VideoCaptureParams& params,

+ const media::VideoCaptureFormat& format,

const VideoCaptureDeliverFrameCB& frame_callback) = 0;

void OnStartDone(MediaStreamRequestResult result);