chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm - Issue 528213004: Don't try to show the Mac password bubble on an inactive tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

Issue 528213004: Don't try to show the Mac password bubble on an inactive tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

index 3b2a75f758bde0651eba9e151976da5dcab36072..4c46675ddbca2142dbc27b54e7680374717c6ed3 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm

@@ -51,6 +51,10 @@ void ShowManagePasswordsBubble(content::WebContents* webContents) {

ManagePasswordsUIController* controller =

ManagePasswordsUIController::FromWebContents(webContents);

NSWindow* window = webContents->GetTopLevelNativeWindow();

+ if (!window) {

+ // The tab isn't active right now.

+ return;

+ }

BrowserWindowController* bwc =

[BrowserWindowController browserWindowControllerForWindow:window];

ManagePasswordsBubbleCocoa::ShowBubble(

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm » ('j') | no next file with comments »