Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 528083002: Roll ICU to 291774 (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow), jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll ICU to 291774 See https://codereview.chromium.org/497543003 fast/encoding/api/ascii-supersets.html has to be rebaselined because now that Shift_JIS acts as an ASCII superset. See https://codereview.chromium.org/513413003/ BUG=277062, 404445 TEST=Blink: fast/encoding/* all pass except for fast/encoding/api/ascii-supersets.html that should fail by *passing* the test for Shift_JIS, which is expected to fail. Blink layout tests needs to be updated. TEST=browser_tests --gtest_filter="*ncoding*" TEST=In JS console, run the following to check if Europe/Moscow is 3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and if Asia/Kamchatka remains 12 hrs ahead of UTC. nov1_2014_1500=new Date("11/01/2014 15:00Z") nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"}) nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"}) nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"}) oct24_2014_1500=new Date("10/24/2014 15:00Z") oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"}) oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"}) oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"}) TEST=net_unittest --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TBR=jsbell@chromium.org, nkostylev@chromium.org Committed: https://crrev.com/08560e0d4c6f016bd1a6bb05020a36cb50c523cc Cr-Commit-Position: refs/heads/master@{#293034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
jungshik at Google
I'll TBR this.
6 years, 3 months ago (2014-09-02 22:12:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/528083002/1
6 years, 3 months ago (2014-09-02 22:13:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 23:12:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as f0032027631047d4281ecbfd45669233aae1664f
6 years, 3 months ago (2014-09-03 01:02:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08560e0d4c6f016bd1a6bb05020a36cb50c523cc Cr-Commit-Position: refs/heads/master@{#293034}
6 years, 3 months ago (2014-09-10 03:22:21 UTC) #6
Nikita (slow)
6 years, 3 months ago (2014-09-11 22:25:08 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698