Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 497543003: Update tz data to 2014f and add SJIS for the encoding spec (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow), jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Update tz data to 2014f and add SJIS for the encoding spec 1. Timezone data files (4 of them) in source/data/misc to 2014f (the latest) to prepare for an upcoming Russian timezone change. 2. Add Shift_JIS converter compliant to the WHATWG encoding spec. 3. Update converters.txt and ucmlocal.mk accordingly 4. Update the pre-built data files for Linux/Mac/Android/Windows. (icudt.dll is not updated in this CL. It's not used in the default configuration. It'll be updated in a separate CL). 5. Fix a typo in ibm866_gen.sh. The acual table used does not need a change. BUG=277062, 404445 TEST=After rolling icu to this revision, the following tests should pass. TEST=Blink: fast/encoding/* all pass except for fast/encoding/api/ascii-supersets.html that should fail by *passing* the test for Shift_JIS, which is expected to fail. Blink layout tests needs to be updated. TEST=browser_tests --gtest_filter="*ncoding*" TEST=In JS console, run the following to check if Europe/Moscow is 3 hrs ahead of UTC after Oct 26 and 4 hrs ahead before that and if Asia/Kamchatka remains 12 hrs ahead of UTC. nov1_2014_1500=new Date("11/01/2014 15:00Z") nov1_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"}) nov1_2014_1500.toLocaleString("en", {timeZone: "UTC"}) nov1_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"}) oct24_2014_1500=new Date("10/24/2014 15:00Z") oct24_2014_1500.toLocaleString("en", {timeZone: "Europe/Moscow"}) oct24_2014_1500.toLocaleString("en", {timeZone: "UTC"}) oct24_2014_1500.toLocaleString("en", {timeZone: "Asia/Kamchatka"}) TEST=net_unittest --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291774

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : add data files #

Patch Set 5 : sjis table updated #

Patch Set 6 : #

Patch Set 7 : update sjis to cover U+0080 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10920 lines, -1177 lines) Patch
M README.chromium View 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M android/icudtl.dat View Binary file 0 comments Download
M patches/converters.patch View 3 4 5 6 8 chunks +23 lines, -12 lines 0 comments Download
M scripts/ibm866_gen.sh View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A scripts/sjis_gen.sh View 1 2 3 4 5 6 1 chunk +122 lines, -0 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/mappings/convrtrs.txt View 3 4 5 6 2 chunks +5 lines, -7 lines 0 comments Download
A source/data/mappings/shift_jis-html5.ucm View 1 2 3 4 5 6 1 chunk +9633 lines, -0 lines 0 comments Download
M source/data/mappings/ucmlocal.mk View 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/misc/metaZones.txt View 3 4 5 6 17 chunks +68 lines, -59 lines 0 comments Download
M source/data/misc/timezoneTypes.txt View 3 4 5 6 5 chunks +6 lines, -4 lines 0 comments Download
M source/data/misc/windowsZones.txt View 4 chunks +4 lines, -3 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 3 4 5 6 114 chunks +1051 lines, -1085 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jungshik at Google
Can you take a look?
6 years, 3 months ago (2014-08-29 23:15:41 UTC) #2
jsbell
lgtm
6 years, 3 months ago (2014-09-02 18:40:20 UTC) #3
jungshik at Google
6 years, 3 months ago (2014-09-02 20:56:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 (id:80001) manually as r291774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698