chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js - Issue 52743002: Declarative rules should be removed on uninstalling, not unloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js

Issue 52743002: Declarative rules should be removed on uninstalling, not unloading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Further comments addressed Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js

diff --git a/chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js b/chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js

index 6e43bff73475da36e93f7a33eb9f648c2b111746..9370314e9d531a9ecf7fe5e3d6017caed0333d51 100644

--- a/chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js

+++ b/chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js

@@ -10,7 +10,8 @@ var redirectDataURI = 'data:text/html;charset=utf-8,<html><head><title>' +

var rule = {

conditions: [

- new chrome.declarativeWebRequest.RequestMatcher({})

+ new chrome.declarativeWebRequest.RequestMatcher({

+ url: {schemes: ['http']}})

actions: [

new chrome.declarativeWebRequest.RedirectRequest({

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc ('k') | no next file » | no next file with comments »