chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 52743002: Declarative rules should be removed on uninstalling, not unloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 52743002: Declarative rules should be removed on uninstalling, not unloading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Further comments addressed Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_unittest.cc ('k') | chrome/test/data/extensions/api_test/declarative/redirect_to_data/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index 84ae04e949c8349652f6039216d8df5fac9b84d4..f0c392c852badff79dccd36fde32a2ebda22b371 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -203,13 +203,13 @@ TEST_F(RulesRegistryWithCacheTest, GetAllRules) {

kRule2Id == *(gotten_rules[0]->id)) );

}

-TEST_F(RulesRegistryWithCacheTest, OnExtensionUnloaded) {

+TEST_F(RulesRegistryWithCacheTest, OnExtensionUninstalled) {

// Prime registry.

EXPECT_EQ("", AddRule(kExtensionId, kRuleId));

EXPECT_EQ("", AddRule(kExtension2Id, kRuleId));

// Check that the correct rules are removed.

- registry_->OnExtensionUnloaded(kExtensionId);

+ registry_->OnExtensionUninstalled(kExtensionId);

EXPECT_EQ(0, GetNumberOfRules(kExtensionId));

EXPECT_EQ(1, GetNumberOfRules(kExtension2Id));

}