Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 527363002: [Android] Clear backing SkBitmap before rendering the overscroll effect (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

[Android] Clear backing SkBitmap before rendering the overscroll effect Skia makes no guarantees about the contents of a newly allocated SkBitmap. Consequently, it's possible that the bitmap allocated for the overscroll effect isn't zeroed before the effect itself is painted. Prevent related issues by always clearing the allocated SkBitmap's contents (to fully transparent) before painting the effect. BUG=408225 TBR=aelias@chromium.org Review URL: https://codereview.chromium.org/484373004 Cr-Commit-Position: refs/heads/master@{#292280} (cherry picked from commit 46c0ec38bed034b6fcaade3f23258bd796a93db6)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/android/system_ui_resource_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jdduke (slow)
6 years, 3 months ago (2014-09-02 15:31:03 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as 33de363 (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698