Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 484373004: [Android] Clear backing SkBitmap before rendering the overscroll effect (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Clear backing SkBitmap before rendering the overscroll effect Skia makes no guarantees about the contents of a newly allocated SkBitmap. Consequently, it's possible that the bitmap allocated for the overscroll effect isn't zeroed before the effect itself is painted. Prevent related issues by always clearing the allocated SkBitmap's contents (to fully transparent) before painting the effect. BUG=408225 Committed: https://crrev.com/46c0ec38bed034b6fcaade3f23258bd796a93db6 Cr-Commit-Position: refs/heads/master@{#292280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/android/system_ui_resource_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jdduke (slow)
jdduke@chromium.org changed reviewers: + aelias@chromium.org
6 years, 3 months ago (2014-08-27 22:02:46 UTC) #1
jdduke (slow)
aelias@: PTAL. I wasn't able to repro even with M38 official builds, and askatte@ mentioned ...
6 years, 3 months ago (2014-08-27 22:02:46 UTC) #2
aelias_OOO_until_Jul13
lgtm I would still like to see a repro, although this change is definitely safe.
6 years, 3 months ago (2014-08-27 22:16:11 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 3 months ago (2014-08-27 22:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/484373004/1
6 years, 3 months ago (2014-08-27 22:26:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:23:20 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:23:21 UTC) #7
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org
6 years, 3 months ago (2014-08-27 23:52:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/484373004/1
6 years, 3 months ago (2014-08-28 00:07:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 37b60fb9573707e4510ac57cf145d7f7709533ac
6 years, 3 months ago (2014-08-28 00:30:45 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46c0ec38bed034b6fcaade3f23258bd796a93db6
Cr-Commit-Position: refs/heads/master@{#292280}

Powered by Google App Engine
This is Rietveld 408576698