Issue 527173002: Add support for storage type to base::Flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 527173002: Add support for storage type to base::Flags. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Add support for storage type to base::Flags. Also drop the DEFINE_FLAGS() macro, and use the typedef explicitly. TEST=base-unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23578

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	src/base/flags.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/base/flags-unittest.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/compiler/linkage.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

6 years, 3 months ago (2014-09-02 06:53:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23578 (presubmit successful).