Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/base/flags-unittest.cc

Issue 527173002: Add support for storage type to base::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Windows Fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/flags.h ('k') | src/compiler/linkage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/flags-unittest.cc
diff --git a/src/base/flags-unittest.cc b/src/base/flags-unittest.cc
index da526cb12160faf63bff7a5f41899de46dc15394..a1d6f3703a175105b241f673225a197727286146 100644
--- a/src/base/flags-unittest.cc
+++ b/src/base/flags-unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "include/v8stdint.h"
#include "src/base/flags.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -16,7 +17,7 @@ enum Flag1 {
kFlag1Second = 1u << 2,
kFlag1All = kFlag1None | kFlag1First | kFlag1Second
};
-DEFINE_FLAGS(Flags1, Flag1);
+typedef Flags<Flag1> Flags1;
DEFINE_OPERATORS_FOR_FLAGS(Flags1)
@@ -60,7 +61,7 @@ enum Option {
kOption2 = 2,
kAllOptions = kNoOptions | kOption1 | kOption2
};
-DEFINE_FLAGS(Options, Option);
+typedef Flags<Option> Options;
} // namespace foo
@@ -82,7 +83,7 @@ namespace {
struct Foo {
enum Enum { kEnum1 = 1, kEnum2 = 2 };
- DEFINE_FLAGS(Enums, Enum);
+ typedef Flags<Enum, uint32_t> Enums;
};
« no previous file with comments | « src/base/flags.h ('k') | src/compiler/linkage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698