Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 527103003: Further cleanup of RenderText (Closed)

Created:
6 years, 3 months ago by Tomasz Moniuszko
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Further cleanup of RenderText Remove redundant data member and include. Followup after https://codereview.chromium.org/493363006 BUG=388084 Committed: https://crrev.com/17657629ccd75c5fa76019f06da04d4ceec2367f Cr-Commit-Position: refs/heads/master@{#292982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M ui/gfx/render_text.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Tomasz Moniuszko
6 years, 3 months ago (2014-09-02 14:52:22 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-02 14:58:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/527103003/1
6 years, 3 months ago (2014-09-02 15:01:57 UTC) #6
msw
lgtm, thanks!
6 years, 3 months ago (2014-09-02 19:22:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as e85600d369d351160e1228335178f1748f6dad49
6 years, 3 months ago (2014-09-02 19:59:21 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17657629ccd75c5fa76019f06da04d4ceec2367f
Cr-Commit-Position: refs/heads/master@{#292982}

Powered by Google App Engine
This is Rietveld 408576698