Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 493363006: Remove deferred fade shader workaround from RenderText (Closed)

Created:
6 years, 3 months ago by Tomasz Moniuszko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, reed2, bungeman-chromium, Alexei Svitkine (slow), ckocagil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deferred fade shader workaround from RenderText BUG=388084 Committed: https://crrev.com/ff68cff3bf62886d125ce8ae385e7084face6e39 Cr-Commit-Position: refs/heads/master@{#292650}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove deferred fade shader workaround from RenderText #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -39 lines) Patch
M ui/gfx/render_text.h View 1 2 chunks +1 line, -3 lines 2 comments Download
M ui/gfx/render_text.cc View 1 4 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Tomasz Moniuszko
tmoniuszko@opera.com changed reviewers: + msw@chromium.org
6 years, 3 months ago (2014-08-27 07:20:35 UTC) #1
Tomasz Moniuszko
6 years, 3 months ago (2014-08-27 07:20:54 UTC) #2
msw
I wonder if this is the right fix, given the work done in <https://code.google.com/p/skia/issues/detail?id=590>. Perhaps ...
6 years, 3 months ago (2014-08-27 19:16:40 UTC) #3
Tomasz Moniuszko
On 2014/08/27 19:16:40, msw wrote: > I wonder if this is the right fix, given ...
6 years, 3 months ago (2014-08-29 13:11:23 UTC) #4
Alexei Svitkine (slow)
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
6 years, 3 months ago (2014-08-29 14:19:25 UTC) #5
Alexei Svitkine (slow)
sweet, lgtm!
6 years, 3 months ago (2014-08-29 14:19:25 UTC) #6
Tomasz Moniuszko
The CQ bit was checked by tmoniuszko@opera.com
6 years, 3 months ago (2014-08-29 14:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/493363006/20001
6 years, 3 months ago (2014-08-29 14:34:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-29 15:46:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7b27f09661cf8814103dee68a36fb3d59533d0b0
6 years, 3 months ago (2014-08-29 16:32:54 UTC) #10
msw
Thanks for cleaning up the workaround, just a could comments, would you mind landing a ...
6 years, 3 months ago (2014-08-29 17:00:33 UTC) #11
Tomasz Moniuszko
On 2014/08/29 17:00:33, msw wrote: > Thanks for cleaning up the workaround, just a could ...
6 years, 3 months ago (2014-09-02 14:55:15 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff68cff3bf62886d125ce8ae385e7084face6e39
Cr-Commit-Position: refs/heads/master@{#292650}

Powered by Google App Engine
This is Rietveld 408576698