Make concrete classes for individual call descriptors.

Make concrete classes for individual call descriptors. The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information.

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23639

[mvstanton, 2014-09-02 11:52:32]

mvstanton@chromium.org changed reviewers:
+ yangguo@chromium.org

[mvstanton, 2014-09-02 11:52:33]

Hi Yang,
Okay this one is a bit large, for two reasons:
1) Creation of concrete classes for each descriptor. Only a few so far benefit
from this, but more and more will get register specifications in them soon.
2) ic-conventions.h is folded into the new descriptor classes, so this was a
lengthy search/replace that touched a lot of lines.

I'll address the ports. Thanks for your time/effort!
--Michael

[mvstanton, 2014-09-02 13:12:42]

Uploaded ports and rebased, thx!
--Michael

[Yang, 2014-09-03 09:24:34]

LGTM with comments. You can address them in a follow up CL since this one is
already getting quite large.

https://codereview.chromium.org/527093002/diff/140001/src/arm/interface-descr...
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/527093002/diff/140001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:22: return
LoadDescriptor::ReceiverRegister();
Looks like you could just subclass VectorLoadICDescriptor from LoadDescriptor.

https://codereview.chromium.org/527093002/diff/140001/src/arm/interface-descr...
src/arm/interface-descriptors-arm.cc:41: return
StoreDescriptor::ReceiverRegister();
Same here with ElementTransitionAndStoreDescriptor/StoreDescriptor.

https://codereview.chromium.org/527093002/diff/140001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/527093002/diff/140001/src/code-stubs.cc#newco...
src/code-stubs.cc:37: major_ = major;
not sure whether an initialization list would be more readable.

https://codereview.chromium.org/527093002/diff/140001/src/interface-descripto...
File src/interface-descriptors.h (right):

https://codereview.chromium.org/527093002/diff/140001/src/interface-descripto...
src/interface-descriptors.h:117: : data_(isolate->call_descriptor_data(key)) {}
Can we simply
- fetch data from the isolate
- check whether it's initialized
- if not, initialize it by calling a virtual Initialize method defined on each
CallInterfaceDescriptor

That way we get rid of that eager initializiation in InitializeForIsolate, and
have on-demand lazy initialization.

The Initialize method could either be the way it is, passing isolate and
descriptor key, or it would simply pass a reference to an uninitialized
CallDescriptorData object already fetched via isolate->call_descriptor_data(key)
and would fill it accordingly. That way we could also get rid of the static
InitializeData method, which is essentially just a wrapper to fetch
isolate->call_descriptor_data(key).

https://codereview.chromium.org/527093002/diff/140001/src/interface-descripto...
src/interface-descriptors.h:120: return data() != NULL &&
data()->IsInitialized();
We then would also not need this any more. The constructor would make sure that
we have data_ set and that data_ is initialized.

[mvstanton, 2014-09-03 10:52:34]

Committed patchset #8 (id:140001) manually as 23639 (presubmit successful).