Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: src/hydrogen-instructions.h

Issue 527093002: Make concrete classes for individual call descriptors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 5ddf6c584b507cdb19fa52b47f6c0f1e1f48eaf0..c6a66b04d861334b4610903998bd2a081f06f6ba 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -2320,9 +2320,9 @@ class HCallWithDescriptor FINAL : public HInstruction {
public:
static HCallWithDescriptor* New(Zone* zone, HValue* context, HValue* target,
int argument_count,
- const CallInterfaceDescriptor* descriptor,
+ CallInterfaceDescriptor descriptor,
const Vector<HValue*>& operands) {
- DCHECK(operands.length() == descriptor->GetEnvironmentLength());
+ DCHECK(operands.length() == descriptor.GetEnvironmentLength());
HCallWithDescriptor* res =
new(zone) HCallWithDescriptor(target, argument_count,
descriptor, operands, zone);
@@ -2342,8 +2342,8 @@ class HCallWithDescriptor FINAL : public HInstruction {
return Representation::Tagged();
} else {
int par_index = index - 1;
- DCHECK(par_index < descriptor_->GetEnvironmentLength());
- return descriptor_->GetParameterRepresentation(par_index);
+ DCHECK(par_index < descriptor_.GetEnvironmentLength());
+ return descriptor_.GetParameterRepresentation(par_index);
}
}
@@ -2361,7 +2361,7 @@ class HCallWithDescriptor FINAL : public HInstruction {
return -argument_count_;
}
- const CallInterfaceDescriptor* descriptor() const { return descriptor_; }
+ CallInterfaceDescriptor descriptor() const { return descriptor_; }
HValue* target() {
return OperandAt(0);
@@ -2372,10 +2372,10 @@ class HCallWithDescriptor FINAL : public HInstruction {
private:
// The argument count includes the receiver.
HCallWithDescriptor(HValue* target, int argument_count,
- const CallInterfaceDescriptor* descriptor,
+ CallInterfaceDescriptor descriptor,
const Vector<HValue*>& operands, Zone* zone)
: descriptor_(descriptor),
- values_(descriptor->GetEnvironmentLength() + 1, zone) {
+ values_(descriptor.GetEnvironmentLength() + 1, zone) {
argument_count_ = argument_count;
AddOperand(target, zone);
for (int i = 0; i < operands.length(); i++) {
@@ -2395,7 +2395,7 @@ class HCallWithDescriptor FINAL : public HInstruction {
values_[index] = value;
}
- const CallInterfaceDescriptor* descriptor_;
+ CallInterfaceDescriptor descriptor_;
ZoneList<HValue*> values_;
int argument_count_;
};

Powered by Google App Engine
This is Rietveld 408576698