Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 527016: Added gyp file for examples. Removed unnecessary functions. Added header file... (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Added gyp file for examples. Removed unnecessary functions. Added header files for two examples and changed a few function signatures so they can be compiled as static libraries. BUG=26099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35856

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 10

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -715 lines) Patch
A third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.h View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c View 1 2 3 4 5 6 7 8 4 chunks +45 lines, -130 lines 0 comments Download
A third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h View 1 2 3 4 5 6 7 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.c View 1 2 3 4 5 6 7 8 6 chunks +14 lines, -57 lines 0 comments Download
M third_party/gles_book_examples/Common/Include/esUtil.h View 1 2 3 4 5 6 7 8 12 chunks +26 lines, -109 lines 0 comments Download
M third_party/gles_book_examples/Common/Include/esUtil_win.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -35 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/Win32/esUtil_TGA.c View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/gles_book_examples/Common/Source/Win32/esUtil_win32.c View 1 2 4 5 8 1 chunk +0 lines, -183 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esShader.c View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esShapes.c View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esTransform.c View 1 2 3 4 5 6 7 8 9 chunks +9 lines, -17 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esUtil.c View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -176 lines 0 comments Download
M third_party/gles_book_examples/README.chromium View 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/gles_book_examples/gles_book_examples.gyp View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alokp
10 years, 11 months ago (2010-01-07 05:41:14 UTC) #1
vangelis
Do you need to modify the readme file to reflect on the additional changes you ...
10 years, 11 months ago (2010-01-07 19:10:06 UTC) #2
alokp
http://codereview.chromium.org/527016/diff/3006/2009 File third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c (right): http://codereview.chromium.org/527016/diff/3006/2009#newcode36 third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c:36: // TODO(alokp): Shaders containing "precision" do not compile. On ...
10 years, 11 months ago (2010-01-07 20:35:58 UTC) #3
alokp
Also modified README.chromium to reflect additional changes.
10 years, 11 months ago (2010-01-07 20:42:37 UTC) #4
vangelis
LGTM http://codereview.chromium.org/527016/diff/3006/2018 File third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h (right): http://codereview.chromium.org/527016/diff/3006/2018#newcode14 third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h:14: // This is a simple example that draws ...
10 years, 11 months ago (2010-01-07 23:22:09 UTC) #5
alokp
10 years, 11 months ago (2010-01-07 23:27:11 UTC) #6
http://codereview.chromium.org/527016/diff/3006/2018
File
third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h
(right):

http://codereview.chromium.org/527016/diff/3006/2018#newcode14
third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h:14:
//    This is a simple example that draws a rotating cube in perspective
Done. I also removed similar comment from Hello_Triangle.h.

Powered by Google App Engine
This is Rietveld 408576698