Chromium Code Reviews
Help | Chromium Project | Sign in
(39)

Issue 527016: Added gyp file for examples. Removed unnecessary functions. Added header file... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Alok Priyadarshi
Modified:
2 years, 10 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Added gyp file for examples. Removed unnecessary functions. Added header files for two examples and changed a few function signatures so they can be compiled as static libraries.
BUG=26099
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35856

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 10

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -715 lines) Lint Patch
A third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.h View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments 17 errors Download
M third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c View 1 2 3 4 5 6 7 8 4 chunks +45 lines, -130 lines 0 comments 66 errors Download
A third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h View 1 2 3 4 5 6 7 1 chunk +54 lines, -0 lines 0 comments 32 errors Download
M third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.c View 1 2 3 4 5 6 7 8 6 chunks +14 lines, -57 lines 0 comments 21 errors Download
M third_party/gles_book_examples/Common/Include/esUtil.h View 1 2 3 4 5 6 7 8 12 chunks +26 lines, -109 lines 0 comments 31 errors Download
M third_party/gles_book_examples/Common/Include/esUtil_win.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -35 lines 0 comments 2 errors Download
M third_party/gles_book_examples/Common/Source/Win32/esUtil_TGA.c View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
D third_party/gles_book_examples/Common/Source/Win32/esUtil_win32.c View 1 2 4 5 8 1 chunk +0 lines, -183 lines 0 comments 0 errors Download
M third_party/gles_book_examples/Common/Source/esShader.c View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments 5 errors Download
M third_party/gles_book_examples/Common/Source/esShapes.c View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -5 lines 0 comments 9 errors Download
M third_party/gles_book_examples/Common/Source/esTransform.c View 1 2 3 4 5 6 7 8 9 chunks +9 lines, -17 lines 0 comments 4 errors Download
M third_party/gles_book_examples/Common/Source/esUtil.c View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -176 lines 0 comments 8 errors Download
M third_party/gles_book_examples/README.chromium View 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
A third_party/gles_book_examples/gles_book_examples.gyp View 1 chunk +60 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
Alok Priyadarshi
4 years, 3 months ago #1
vangelis
Do you need to modify the readme file to reflect on the additional changes you ...
4 years, 3 months ago #2
Alok Priyadarshi
http://codereview.chromium.org/527016/diff/3006/2009 File third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c (right): http://codereview.chromium.org/527016/diff/3006/2009#newcode36 third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c:36: // TODO(alokp): Shaders containing "precision" do not compile. On ...
4 years, 3 months ago #3
Alok Priyadarshi
Also modified README.chromium to reflect additional changes.
4 years, 3 months ago #4
vangelis
LGTM http://codereview.chromium.org/527016/diff/3006/2018 File third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h (right): http://codereview.chromium.org/527016/diff/3006/2018#newcode14 third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h:14: // This is a simple example that draws ...
4 years, 3 months ago #5
Alok Priyadarshi
4 years, 3 months ago #6
http://codereview.chromium.org/527016/diff/3006/2018
File
third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h
(right):

http://codereview.chromium.org/527016/diff/3006/2018#newcode14
third_party/gles_book_examples/Chapter_8/Simple_VertexShader/Simple_VertexShader.h:14:
//    This is a simple example that draws a rotating cube in perspective
Done. I also removed similar comment from Hello_Triangle.h.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6