Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 526973003: Use the blink main thread isolate for v8 unit tests. (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use the blink main thread isolate for v8 unit tests. The TestWebKitPlatformSupport will initialize it for us anyway, so use it. BUG=none R=andrewhayden@chromium.org,haraken@chromium.org Committed: https://crrev.com/1314956e68fd3a7997dcc3ee190f230bd43275e8 Cr-Commit-Position: refs/heads/master@{#292951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -57 lines) Patch
M chrome/test/base/v8_unit_test.h View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/test/base/v8_unit_test.cc View 6 chunks +39 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-02 13:39:47 UTC) #1
Andrew Hayden (chromium.org)
This L*gtm, but I have almost no context here. I am surprised that "mainThreadIsolate" isn't ...
6 years, 3 months ago (2014-09-02 13:50:11 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-02 14:55:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/526973003/1
6 years, 3 months ago (2014-09-02 16:23:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 951da38c1b91e24ce31cc3342f5867baf3146701
6 years, 3 months ago (2014-09-02 17:15:07 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1314956e68fd3a7997dcc3ee190f230bd43275e8
Cr-Commit-Position: refs/heads/master@{#292951}

Powered by Google App Engine
This is Rietveld 408576698