Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/test/base/v8_unit_test.h

Issue 526973003: Use the blink main thread isolate for v8 unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/v8_unit_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/v8_unit_test.h
diff --git a/chrome/test/base/v8_unit_test.h b/chrome/test/base/v8_unit_test.h
index 4b056d3c4d02e7fe320da08a4f01c8a87c2c4d36..b12238f007f549218ede3a4adfb2a85d5e5c5929 100644
--- a/chrome/test/base/v8_unit_test.h
+++ b/chrome/test/base/v8_unit_test.h
@@ -68,36 +68,12 @@ class V8UnitTest : public testing::Test {
static void ChromeSend(const v8::FunctionCallbackInfo<v8::Value>& args);
private:
- // A helper class to ensure that the lifetimes of the Isolate and the
- // HandleScope are correctly nested.
- class IsolateScope {
- public:
- IsolateScope() : isolate_(v8::Isolate::New()) { isolate_->Enter(); }
-
- ~IsolateScope() {
- isolate_->Exit();
- isolate_->Dispose();
- }
-
- v8::Isolate* isolate() const { return isolate_; }
-
- private:
- v8::Isolate* isolate_;
-
- DISALLOW_COPY_AND_ASSIGN(IsolateScope);
- };
-
- // A handy shortcut.
- v8::Isolate* isolate() const { return isolate_scope_.isolate(); }
-
// Executes all added javascript libraries. Returns true if no errors.
bool ExecuteJavascriptLibraries();
// Initializes paths and libraries.
void InitPathsAndLibraries();
- IsolateScope isolate_scope_;
-
// Handle scope that is used throughout the life of this class.
v8::HandleScope handle_scope_;
« no previous file with comments | « no previous file | chrome/test/base/v8_unit_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698