 Chromium Code Reviews
 Chromium Code Reviews Issue 526953004:
  Lazy deoptimization for comparisons in Turbofan.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 526953004:
  Lazy deoptimization for comparisons in Turbofan.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/compiler/verifier.cc | 
| diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc | 
| index 97ebb8fb691d6a62e8a6111432d5ddad488cfe81..ce5e745c2cdc32a0b9da60045185919f8f791bbc 100644 | 
| --- a/src/compiler/verifier.cc | 
| +++ b/src/compiler/verifier.cc | 
| @@ -73,6 +73,12 @@ GenericGraphVisit::Control Verifier::Visitor::Pre(Node* node) { | 
| effect_count + control_count; | 
| CHECK_EQ(input_count, node->InputCount()); | 
| + // Verify that frame state has been inserted for the nodes that need it. | 
| + if (OperatorProperties::HasFrameStateInput(node->op())) { | 
| + CHECK(NodeProperties::GetFrameStateInput(node)->op()->opcode() == | 
| 
Michael Starzinger
2014/09/01 23:10:46
nit: There should be Node::opcode() directly IIRC.
 | 
| + IrOpcode::kFrameState); | 
| 
Michael Starzinger
2014/09/01 23:10:46
suggestion: Do you think it makes sense to check t
 | 
| + } | 
| + | 
| // Verify all value inputs actually produce a value. | 
| for (int i = 0; i < value_count; ++i) { | 
| Node* value = NodeProperties::GetValueInput(node, i); |