Lazy deoptimization for comparisons in Turbofan.

src/compiler/verifier.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/verifier.h"
 
 #include <deque>
 #include <queue>
 
 #include "src/compiler/generic-algorithm.h"
@@ skipping 55 matching lines @@
   int frame_state_count =
       OperatorProperties::GetFrameStateInputCount(node->op());
   int effect_count = OperatorProperties::GetEffectInputCount(node->op());
   int control_count = OperatorProperties::GetControlInputCount(node->op());
 
   // Verify number of inputs matches up.
   int input_count = value_count + context_count + frame_state_count +
                     effect_count + control_count;
   CHECK_EQ(input_count, node->InputCount());
 
+  // Verify that frame state has been inserted for the nodes that need it.
+  if (OperatorProperties::HasFrameStateInput(node->op())) {
+    CHECK(NodeProperties::GetFrameStateInput(node)->op()->opcode() ==

[Michael Starzinger, 2014/09/01 23:10:46]

nit: There should be Node::opcode() directly IIRC.

+          IrOpcode::kFrameState);

[Michael Starzinger, 2014/09/01 23:10:46]

suggestion: Do you think it makes sense to check that def-use and use-def chains
are present (i.e. Is[DefUse|UseDef]ChainLinkPresent)?

+  }
+
   // Verify all value inputs actually produce a value.
   for (int i = 0; i < value_count; ++i) {
     Node* value = NodeProperties::GetValueInput(node, i);
     CHECK(OperatorProperties::HasValueOutput(value->op()));
     CHECK(IsDefUseChainLinkPresent(value, node));
     CHECK(IsUseDefChainLinkPresent(value, node));
   }
 
   // Verify all context inputs are value nodes.
   for (int i = 0; i < context_count; ++i) {
@@ skipping 348 matching lines @@
     // Check inputs for all nodes in the block.
     for (size_t i = 0; i < block->nodes_.size(); i++) {
       Node* node = block->nodes_[i];
       CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
     }
   }
 }
 }
 }
 }  // namespace v8::internal::compiler