Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 526373002: Fix bug in graph visualizer. (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/compiler/graph-visualizer.cc View 1 chunk +7 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
sigurds
As reported offline.
6 years, 3 months ago (2014-09-02 14:23:10 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc#newcode215 src/compiler/graph-visualizer.cc:215: << (NodeProperties::IsContextEdge(edge) ? "style=dashed, " : "") << ...
6 years, 3 months ago (2014-09-02 14:34:03 UTC) #2
Michael Starzinger
https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc#newcode215 src/compiler/graph-visualizer.cc:215: << (NodeProperties::IsContextEdge(edge) ? "style=dashed, " : "") << "]"; ...
6 years, 3 months ago (2014-09-02 14:34:33 UTC) #3
sigurds
On 2014/09/02 14:34:33, Michael Starzinger wrote: > https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc > File src/compiler/graph-visualizer.cc (right): > > https://codereview.chromium.org/526373002/diff/1/src/compiler/graph-visualizer.cc#newcode215 ...
6 years, 3 months ago (2014-09-02 14:42:15 UTC) #4
sigurds
6 years, 3 months ago (2014-09-02 14:59:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698