Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 526373002: Fix bug in graph visualizer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 0edc0d3d5cbe614d1e3f9d87759d795ca8e0540e..10d6698a2cbeacde0be30471d1db346c30ea8c16 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -209,14 +209,14 @@ void GraphVisualizer::PrintEdge(Node::Edge edge) {
(OperatorProperties::GetControlInputCount(from->op()) > 0 &&
NodeProperties::GetControlInput(from) != to)) {
os_ << ":I" << index << ":n -> ID" << to->id() << ":s"
- << "[" << (unconstrained ? "constraint=false" : "")
- << (NodeProperties::IsControlEdge(edge) ? "style=bold" : "")
- << (NodeProperties::IsEffectEdge(edge) ? "style=dotted" : "")
- << (NodeProperties::IsContextEdge(edge) ? "style=dashed" : "") << "]";
+ << "[" << (unconstrained ? "constraint=false, " : "")
+ << (NodeProperties::IsControlEdge(edge) ? "style=bold, " : "")
+ << (NodeProperties::IsEffectEdge(edge) ? "style=dotted, " : "")
+ << (NodeProperties::IsContextEdge(edge) ? "style=dashed, " : "") << "]";
Michael Starzinger 2014/09/02 14:34:03 Are trailing slashes OK for GraphViz? I am not a G
Michael Starzinger 2014/09/02 14:34:33 s/slashes/commas/
} else {
- os_ << " -> ID" << to->id() << ":s [color=transparent"
- << (unconstrained ? ", constraint=false" : "")
- << (NodeProperties::IsControlEdge(edge) ? ", style=dashed" : "") << "]";
+ os_ << " -> ID" << to->id() << ":s [color=transparent, "
+ << (unconstrained ? "constraint=false, " : "")
+ << (NodeProperties::IsControlEdge(edge) ? "style=dashed, " : "") << "]";
}
os_ << "\n";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698